[Helper] Add getName method to all MessageHandler implementations and update related tests#5979
Merged
Merged
Conversation
alxbilger
added
pr: enhancement
Contributor
Author
|
[ci-build][with-all-tests] |
Collaborator
|
[ci-depends-on] detected during build #2. To unlock the merge button, you must
|
Contributor
|
Error on Win : J:\0\build\external_directories\fetched\SofaPython3\bindings\Sofa\src\SofaPython3\Sofa\Helper\Binding_MessageHandler.cpp(94): error C2259: 'sofapython3::MessageHandler_Trampoline': cannot instantiate abstract class
J:\0\build\external_directories\fetched\SofaPython3\bindings\Sofa\src\SofaPython3/Sofa/Helper/Binding_MessageHandler.h(38): note: see declaration of 'sofapython3::MessageHandler_Trampoline'
J:\0\build\external_directories\fetched\SofaPython3\bindings\Sofa\src\SofaPython3\Sofa\Helper\Binding_MessageHandler.cpp(94): note: due to following members:
J:\0\build\external_directories\fetched\SofaPython3\bindings\Sofa\src\SofaPython3\Sofa\Helper\Binding_MessageHandler.cpp(94): note: 'std::string sofa::helper::logging::MessageHandler::getName(void) const': is abstract
J:\0\src\Sofa\framework\Helper\src\sofa/helper/logging/MessageHandler.h(43): note: see declaration of 'sofa::helper::logging::MessageHandler::getName'
J:\0\build\external_directories\fetched\SofaPython3\bindings\Sofa\src\SofaPython3\Sofa\Helper\Binding_MessageHandler.cpp(94): error C2259: 'sofapython3::MessageHandler_Trampoline': cannot instantiate abstract class
J:\0\build\external_directories\fetched\SofaPython3\bindings\Sofa\src\SofaPython3/Sofa/Helper/Binding_MessageHandler.h(38): note: see declaration of 'sofapython3::MessageHandler_Trampoline'
J:\0\build\external_directories\fetched\SofaPython3\bindings\Sofa\src\SofaPython3\Sofa\Helper\Binding_MessageHandler.cpp(94): note: due to following members:
J:\0\build\external_directories\fetched\SofaPython3\bindings\Sofa\src\SofaPython3\Sofa\Helper\Binding_MessageHandler.cpp(94): note: 'std::string sofa::helper::logging::MessageHandler::getName(void) const': is abstract
J:\0\src\Sofa\framework\Helper\src\sofa/helper/logging/MessageHandler.h(43): note: see declaration of 'sofa::helper::logging::MessageHandler::getName'
[1488/2411] Building CXX object applications\SofaPython3\bindings\Sofa\src\SofaPython3\Sofa\Helper\CMakeFiles\Bindings.Sofa.Helper.dir\System\Binding_FileRepository.cpp.obj
[1489/2411] Building CXX object applications\SofaPython3\bindings\Sofa\src\SofaPython3\Sofa\Simulation\CMakeFiles\Bindings.Sofa.Simulation.dir\Binding_SceneCheck.cpp.obj
[1490/2411] Linking CXX shared library lib\python3\site-packages\Sofa\Core.cp310-win_amd64.pyd
ninja: build stopped: subcommand failed.
ERROR: Detected /J/0/build/make-failed |
Collaborator
|
[ci-depends-on] detected during build #3. To unlock the merge button, you must
|
fredroy
approved these changes
Mar 19, 2026
th-skam
added
pr: status ready
Collaborator
|
[ci-depends-on] detected during build #4. To unlock the merge button, you must
|
…te related tests
Collaborator
|
[ci-depends-on] detected during build #5. To unlock the merge button, you must
|
Contributor
|
[ci-build][with-all-tests] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It helps for debugging
Breaking because the newly added method is pure virtual.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if